This revision was automatically updated to reflect the committed changes.
Closed by commit rC338263: [analyzer] Add missing state transition in
IteratorChecker. (authored by rkovacs, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47417
Files:
lib/StaticAnalyzer/Checkers/Iter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338263: [analyzer] Add missing state transition in
IteratorChecker. (authored by rkovacs, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4741
baloghadamsoftware added a comment.
Did the tests execute? I am not sure. First problem is the the container may
become dead before the iterator, so its `Begin` and `End` symbols may be
inaccessible. This is easy to solve by marking the container of the iterator as
live. However, there is a sec
baloghadamsoftware accepted this revision.
baloghadamsoftware added a comment.
Oh, it slipped through somehow. Thanks for fixing this!
Repository:
rC Clang
https://reviews.llvm.org/D47417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:399
+
+ C.addTransition(State);
}
NoQ wrote:
> MTC wrote:
> > I have two questions may need @NoQ or @xazax.hun who is more familiar with
> > the analyzer engine help to answ
NoQ added a comment.
Nice catch!
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:399
+
+ C.addTransition(State);
}
MTC wrote:
> I have two questions may need @NoQ or @xazax.hun who is more familiar with
> the analyzer engine help to answer.
>
>
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:399
+
+ C.addTransition(State);
}
I have two questions may need @NoQ or @xazax.hun who is more familiar with the
analyzer engine help to answer.
- `State` may not change
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov, baloghadamsoftware.
Herald added subscribers: a.sidorin, dkrupp, szepet, whisperity.
After cleaning up program state maps in `checkDeadSymbols()`, a transition
should be added to generate the new state.
