[PATCH] D47376: [CUDA][HIP] Do not offload for -M

2018-06-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Just to make it clear, I'm not against making a sensible default choice, but rather want to make sure that it is possible to override it if the user needs to. https://reviews.llvm.org/D47376 ___ cfe-commits mailing list cfe-co

[PATCH] D47376: [CUDA][HIP] Do not offload for -M

2018-06-05 Thread Artem Belevich via Phabricator via cfe-commits
tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. I'm not sure this is the right thing to do. What if user explicitly wants device-side dependencies and runs `clang --cuda-device-only -M` ? This patch makes it impossible. I'd rather tell

[PATCH] D47376: [CUDA][HIP] Do not offload for -M

2018-06-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping https://reviews.llvm.org/D47376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47376: [CUDA][HIP] Do not offload for -M

2018-05-25 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. CUDA and HIP action builder currently tries to do offloading for -M, which causes dependency file not generated. This patch changes action builder so that only host compilation is performed to generate dependency file. This assumes th