martong updated this revision to Diff 149093.
martong added a comment.
- Moved the family of `testImport` functions under a test fixture class, so we
can use parameterized test.
- Refactored `testImport` and `testImportSequence`, because for loops over the
different compiler options is no longer
a.sidorin added a comment.
I meant that we can use this approach for testImport() too.
Repository:
rC Clang
https://reviews.llvm.org/D47367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
martong added a comment.
> I agree with that. I think we need to test just import pairs
> {/*From*/no_option, /*To*/no_option}, {option_1, option1}, {option_2,
> option_2}, ...{option_n, option_n}.
This patch does exactly that with the parameterized tests. Each elements of the
`DefaultTestValu
a.sidorin added a comment.
> I think, it is overkill to test all possible combinations of the options, we
> should come up with something better here.
I agree with that. I think we need to test just import pairs
{/*From*/no_option, /*To*/no_option}, {option_1, option1}, {option_2,
option_2}, .
martong added a comment.
This patch does not target `testImport` because I am not sure how to handle the
options there:
auto RunOptsFrom = getRunOptionsForLanguage(FromLang);
auto RunOptsTo = getRunOptionsForLanguage(ToLang);
for (const auto &FromArgs : RunOptsFrom)
for (const auto &To
martong created this revision.
martong added reviewers: a.sidorin, r.stahl, xazax.hun.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
In order to avoid build failures on MS, we use -fms-compatibility too in the
tests which use the TestBase.
Repository:
rC Clang
https://reviews.llvm.
