[PATCH] D47256: [clangd] Fix code completion in MACROs with stringification.

2018-05-24 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL333174: [clangd] Fix code completion in MACROs with stringification. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47256 F

[PATCH] D47256: [clangd] Fix code completion in MACROs with stringification.

2018-05-24 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47256: [clangd] Fix code completion in MACROs with stringification.

2018-05-23 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 148206. ioeric added a comment. - Fix broken test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47256 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp Index: unittests/clangd/CodeCompleteTests.cpp =

[PATCH] D47256: [clangd] Fix code completion in MACROs with stringification.

2018-05-23 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jkorous, MaskRay, klimek. Currently, we only handle the first callback from sema code completion and ignore results from potential following callbacks. This causes causes loss of completion