This revision was automatically updated to reflect the committed changes.
Prazek marked an inline comment as done.
Closed by commit rC334600: Add -fforce-emit-vtables (authored by Prazek,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47108?vs=150735&id=151154#toc
Repositor
rsmith accepted this revision.
rsmith added a comment.
LGTM with one change.
Comment at: clang/include/clang/Basic/LangOptions.def:292
+BENIGN_LANGOPT(ForceEmitVTables, 1, 0,
+ "whether to emit all vtables")
I don't think this is benign or even
Prazek updated this revision to Diff 150735.
Prazek added a comment.
- Fixed templates
Repository:
rL LLVM
https://reviews.llvm.org/D47108
Files:
clang/docs/ClangCommandLineReference.rst
clang/docs/ReleaseNotes.rst
clang/docs/UsersManual.rst
clang/include/clang/Basic/LangOptions.def
rsmith accepted this revision.
rsmith added a comment.
I would like to see a test that virtual function definitions are properly
emitted for classes instantiated from templates (and in particular, that this
triggers instantiation of such virtual member functions so they can be
emitted). Other t
amharc accepted this revision.
amharc added a comment.
This revision is now accepted and ready to land.
Looks good to me. Obviously, you should wait for someone more competent than me
to accept it, too.
Repository:
rL LLVM
https://reviews.llvm.org/D47108
__
Prazek updated this revision to Diff 148839.
Prazek marked an inline comment as done.
Prazek added a comment.
fixed test
Repository:
rL LLVM
https://reviews.llvm.org/D47108
Files:
clang/docs/ClangCommandLineReference.rst
clang/docs/ReleaseNotes.rst
clang/docs/UsersManual.rst
clang/in
amharc requested changes to this revision.
amharc added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/CodeGenCXX/vtable-available-externally.cpp:445
+// after the Derived construction.
+// CHECK-FORCE-EMIT-DAG: @_ZTVN6Test187DerivedE = lin
Prazek updated this revision to Diff 148764.
Prazek added a comment.
small update
Repository:
rL LLVM
https://reviews.llvm.org/D47108
Files:
clang/docs/ClangCommandLineReference.rst
clang/docs/ReleaseNotes.rst
clang/docs/UsersManual.rst
clang/include/clang/Basic/LangOptions.def
cla
Prazek updated this revision to Diff 148762.
Prazek added a comment.
Fixed missing vtable commponents
Repository:
rL LLVM
https://reviews.llvm.org/D47108
Files:
clang/docs/ClangCommandLineReference.rst
clang/docs/ReleaseNotes.rst
clang/docs/UsersManual.rst
clang/include/clang/Basic/L
rjmccall added a comment.
In https://reviews.llvm.org/D47108#1109145, @Prazek wrote:
> In https://reviews.llvm.org/D47108#1109014, @rjmccall wrote:
>
> > I thought we already had places in Sema that marked inline virtual methods
> > as used, instantiated templates, etc. for devirtualization purp
Prazek added a comment.
In https://reviews.llvm.org/D47108#1109014, @rjmccall wrote:
> I thought we already had places in Sema that marked inline virtual methods as
> used, instantiated templates, etc. for devirtualization purposes when
> optimization was enabled. Did we rip that out?
I only
rjmccall added a comment.
I thought we already had places in Sema that marked inline virtual methods as
used, instantiated templates, etc. for devirtualization purposes when
optimization was enabled. Did we rip that out?
The problem we've had over and over with devirtualization is that we have
Prazek added a comment.
@rjmccall do you have any thoughts on the best way to solve it?
Repository:
rL LLVM
https://reviews.llvm.org/D47108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
13 matches
Mail list logo
