compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
x86-Linux-only test is good. LG with the discussed changes.
Comment at: src/DwarfInstructions.hpp:195
}
+else if (i == (int)cieInfo.returnAddressRegiste
whitequark added a comment.
> It would be nice if we had a test case added for this
This is inherently architecture and platform specific, and libunwind currently
doesn't have any provisions for this... In principle, would a x86-only
Linux-only test suffice? I'm not sure if I can spend time mak
compnerd added a comment.
It would be nice if we had a test case added for this, but, seems correct to me.
Comment at: src/DwarfInstructions.hpp:195
}
+else if (i == (int)cieInfo.returnAddressRegister)
+ returnAddress = registers.getRegister(i);
--
whitequark added a comment.
@compnerd ping
Repository:
rUNW libunwind
https://reviews.llvm.org/D46971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
whitequark updated this revision to Diff 147153.
whitequark added a comment.
Reuploaded diff with context.
Repository:
rUNW libunwind
https://reviews.llvm.org/D46971
Files:
src/DwarfInstructions.hpp
Index: src/DwarfInstructions.hpp
whitequark created this revision.
whitequark added a reviewer: compnerd.
Herald added a subscriber: JDevlieghere.
If prolog info lists the RA register as unused, it means that
the current stack frame corresponds to a leaf function which never
needs to save the RA register. The RA register is of co
