[PATCH] D46903: [Attr] Don't print attr arg with default value

2018-05-15 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny abandoned this revision. jdenny added a comment. After further thought, this patch doesn't seem worthwhile. Sorry for all the noise. https://reviews.llvm.org/D46903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D46903: [Attr] Don't print attr arg with default value

2018-05-15 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. I occurs to me now that I could have fixed __single_inheritance by declaring its argument "fake". However, I still prefer the above solution because (1) it should help with any other attributes where arguments should have been declared fake (but no, I haven't identified

[PATCH] D46903: [Attr] Don't print attr arg with default value

2018-05-15 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. For example, given: class __single_inheritance T; -ast-print -fms-extensions used to print: class __single_inheritance(1) T; Clang fails to parse that because the "(1)" is not valid syntax. This was disc