This revision was automatically updated to reflect the committed changes.
Closed by commit rC333278: [analyzer] Added a getLValue method to ProgramState
for bases (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer
Szelethus added a comment.
Thanks for the review!
If you like the new overload, can you please commit this for me?
https://reviews.llvm.org/D46891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Szelethus updated this revision to Diff 147045.
Szelethus added a comment.
Fixed a typo.
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
Index: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
==
Szelethus updated this revision to Diff 147033.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Added a `CXXRecordDecl` version.
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
Index: include/clang/StaticAnalyze
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:732
+ const SubRegion *Super) const {
+ const auto Base = BaseSpec.getType()->getAsCXXRecordDecl();
+ return loc::MemRegionVal(
--
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good, thanks! Yeah, seems that these were accidentally omitted.
You may want to add the `const CXXRecordDecl *` variant as well.
Repository:
rC Clang
https://reviews.llvm.org/D46891
___
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, NoQ.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, whisperity.
Herald added a reviewer: george.karpenkov.
Repository:
rC Clang
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer/Core
