[PATCH] D46871: [AMDGPU] Add interpolation builtins

2019-01-28 Thread Tim Corringham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC352358: [AMDGPU] Add interpolation builtins (authored by timcorringham, committed by ). Herald added a subscriber: jvesely. Changed prior to commit: https://reviews.llvm.org/D46871?vs=147460&id=183837#t

[PATCH] D46871: [AMDGPU] Add interpolation builtins

2018-07-09 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. Checking the full operands wouldn't hurt though. Repository: rC Clang https://reviews.llvm.org/D46871 ___ cfe-commits mailing list cfe-c

[PATCH] D46871: [AMDGPU] Add interpolation builtins

2018-05-18 Thread Tim Corringham via Phabricator via cfe-commits
timcorringham updated this revision to Diff 147460. timcorringham added a comment. [AMDGPU] Add interpolation builtins Updated LIT test so that it only tests for the existence of the builtins by checking the IR. Repository: rC Clang https://reviews.llvm.org/D46871 Files: include/clang/Bas

[PATCH] D46871: [AMDGPU] Add interpolation builtins

2018-05-18 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: include/clang/Basic/BuiltinsAMDGPU.def:103-107 +BUILTIN(__builtin_amdgcn_interp_p1_f16, "ffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p2_f16, "hffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p1, "ffUiUiUi", "nc") +BUILTIN(__buil

[PATCH] D46871: [AMDGPU] Add interpolation builtins

2018-05-15 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: include/clang/Basic/BuiltinsAMDGPU.def:103-107 +BUILTIN(__builtin_amdgcn_interp_p1_f16, "ffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p2_f16, "hffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p1, "ffUiUiUi", "nc") +BUILTIN(__buil

[PATCH] D46871: [AMDGPU] Add interpolation builtins

2018-05-15 Thread Tim Corringham via Phabricator via cfe-commits
timcorringham added inline comments. Comment at: include/clang/Basic/BuiltinsAMDGPU.def:103-107 +BUILTIN(__builtin_amdgcn_interp_p1_f16, "ffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p2_f16, "hffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p1, "ffUiUiUi", "nc") +BUILTIN

[PATCH] D46871: [AMDGPU] Add interpolation builtins

2018-05-15 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: test/CodeGenOpenCL/builtins-amdgcn-interp.cl:2-28 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -target-cpu gfx900 -S -o - %s | FileCheck %s --check-prefixes=CHECK,GFX9,BANK32 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -targ

[PATCH] D46871: [AMDGPU] Add interpolation builtins

2018-05-15 Thread Tim Corringham via Phabricator via cfe-commits
timcorringham created this revision. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl. Added builtins for the interpolation intrinsics, and related LIT test. Repository: rC Clang https://reviews.llvm.org/D46871 Files: include/clang/Basic/Built