[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

lewis-revill added a comment. I've submitted a patch to address Simon's issues in https://reviews.llvm.org/D50246 Repository: rC Clang https://reviews.llvm.org/D46822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

simoncook added a comment. It seems the ability to link objects has been broken by this change. As an example from our nightly tests: Executing on host: riscv32-unknown-elf-clang /data/jenkins/workspace/riscv32-llvm-gcc/gcc-tests/gcc/testsuite/gcc.c-torture/execute/20080502-1.c -march=rv32g

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

xbolva00 added a comment. In https://reviews.llvm.org/D46822#1183007, @efriedma wrote: > Please don't commit patches on behalf of someone else if the author hasn't > specifically requested it. There might be some issue which the author forgot > to note on the review. Oh, ok. Repository:

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

efriedma added a comment. Please don't commit patches on behalf of someone else if the author hasn't specifically requested it. There might be some issue which the author forgot to note on the review. Repository: rC Clang https://reviews.llvm.org/D46822 _

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

This revision was automatically updated to reflect the committed changes. Closed by commit rC338385: [RISCV] Add driver for riscv32-unknown-elf baremetal target (authored by xbolva00, committed by ). Repository: rC Clang https://reviews.llvm.org/D46822 Files: lib/Driver/CMakeLists.txt lib

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

kito-cheng added a comment. Herald added subscribers: rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, jrtc27. ping, Alex, could you commit that? Repository: rC Clang https://reviews.llvm.org/D46822 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Driver/ToolChains/Gnu.cpp:1885 + "riscv64-unknown-linux-gnu", +

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

efriedma added a comment. Just a brief comment in the code explaining that would be fine. Repository: rC Clang https://reviews.llvm.org/D46822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

asb added a comment. In https://reviews.llvm.org/D46822#1098764, @efriedma wrote: > Could you include some documentation for how to construct a baremetal > environment like the one this code expects? It's not clear what exactly you > expect to be installed where. Thanks for taking a look Eli

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

efriedma added a comment. Could you include some documentation for how to construct a baremetal environment like the one this code expects? It's not clear what exactly you expect to be installed where. Repository: rC Clang https://reviews.llvm.org/D46822

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

asb created this revision. asb added reviewers: efriedma, phosek, apazos. Herald added subscribers: mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar, arichardson, mgorny, emaste. Herald added a reviewer: espindola. This patch a