This revision was automatically updated to reflect the committed changes.
Closed by commit rL332284: [clang-format] Move #include related style to
libToolingCore (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46758
F
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D46758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
ioeric updated this revision to Diff 146598.
ioeric marked an inline comment as done.
ioeric added a comment.
- Remove an unintended change.
Repository:
rC Clang
https://reviews.llvm.org/D46758
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/IncludeStyle.h
lib/Format/Fo
ioeric added inline comments.
Comment at: lib/Format/Format.cpp:2277
auto Replace =
-Includes.insert(trimInclude(IncludeName), IncludeName.startswith("<"));
+Includes.insert(IncludeName.trim("\"<>"), IncludeName.startswith("<"));
if (Replace) {
-
ilya-biryukov added a comment.
LG. Just a quick comment about possibly unrelated change.
Comment at: lib/Format/Format.cpp:2277
auto Replace =
-Includes.insert(trimInclude(IncludeName), IncludeName.startswith("<"));
+Includes.insert(IncludeName.trim("\"<>")
ioeric updated this revision to Diff 146390.
ioeric marked an inline comment as done.
ioeric added a comment.
Herald added a subscriber: mgorny.
- also moved yaml traits.
Repository:
rC Clang
https://reviews.llvm.org/D46758
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/
ilya-biryukov added inline comments.
Comment at: lib/Format/Format.cpp:461
+
+template <> struct MappingTraits {
+ static void mapping(IO &IO, IncludeStyle::IncludeCategory &Category) {
Should we move this to `tooling::Core` too?
If we need to specialize `Mappin
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, klimek.
This will be shared by include insertion/deletion library.
Repository:
rC Clang
https://reviews.llvm.org/D46758
Files:
include/clang/Format/Format.h
include/clang/Tooling/
