This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332448: [diagtool] Add diagtool to install target. (authored
by JDevlieghere, committed by ).
Changed prior to commit:
vsk added a comment.
Sgtm. I think it would be worthwhile to release-note this.
Repository:
rC Clang
https://reviews.llvm.org/D46694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
JDevlieghere added a comment.
In https://reviews.llvm.org/D46694#1094617, @dexonsmith wrote:
> This SGTM, but I wouldn't mind hearing from others. I wonder if this is
> worth a quick RFC on cfe-dev?
Sounds good, I've created a thread here:
http://lists.llvm.org/pipermail/cfe-dev/2018-May/057
dexonsmith added a comment.
This SGTM, but I wouldn't mind hearing from others. I wonder if this is worth
a quick RFC on cfe-dev?
Repository:
rC Clang
https://reviews.llvm.org/D46694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
JDevlieghere created this revision.
JDevlieghere added reviewers: arphaman, dexonsmith, jkorous, rsmith.
Herald added a subscriber: mgorny.
Although not very well known, diagtool is an incredibly convenient utility for
dealing with diagnostics. I believe it's worth adding this to the install
tar
