[PATCH] D46651: [OpenCL] Support placement new/delete in Sema

2018-06-08 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia requested changes to this revision. Anastasia added inline comments. This revision now requires changes to proceed. Comment at: lib/Sema/SemaExprCXX.cpp:2030 + } +} svenvh wrote: > rjmccall wrote: > > I think a better interpretation of this r

[PATCH] D46651: [OpenCL] Support placement new/delete in Sema

2018-05-11 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:2030 + } +} rjmccall wrote: > I think a better interpretation of this rule would be to just error on > attempts to use the standard non-placement operator new/delete instead of > tryi

[PATCH] D46651: [OpenCL] Support placement new/delete in Sema

2018-05-09 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:2030 + } +} I think a better interpretation of this rule would be to just error on attempts to use the standard non-placement operator new/delete instead of trying to outlaw the ope

[PATCH] D46651: [OpenCL] Support placement new/delete in Sema

2018-05-09 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh created this revision. svenvh added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. Stop crashing on placement new/delete in OpenCL C++ mode, and reject non-placement new/delete with a diagnostic instead of a crash. Repository: rC Clang https://reviews.llvm.org/D4