This revision was automatically updated to reflect the committed changes.
Closed by commit rL332378: [clangd] Extract scoring/ranking logic, and shave
yaks. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46524?
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall updated this revision to Diff 146591.
sammccall marked an inline comment as done.
sammccall added a comment.
Doxygen
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46524
Files:
clangd/CMakeLists.txt
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
sammccall updated this revision to Diff 146584.
sammccall added a comment.
fix diffbase?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46524
Files:
clangd/CMakeLists.txt
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/CMakeLists.txt
uni
ilya-biryukov added a comment.
The new uploaded diff has lots of unrelated changes to clang-tidy, clang-move,
etc...
Looking at commits, it seems `arc diff` was called with the wrong base
commit...
Could you please reupload the change?
Comment at: clangd/Quality.h:45
+
+// A
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:909
+
+auto QualScore = Quality.evaluate(), RelScore = Relevance.evaluate();
+CompletionItemScores Scores;
ilya-biryukov wrote:
> NIT: Maybe use `float` here instead of auto? Would remov
sammccall updated this revision to Diff 145478.
sammccall marked 9 inline comments as done.
sammccall added a comment.
Address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46524
Files:
clang-move/ClangMove.cpp
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagno
ilya-biryukov added a comment.
The change makes both testing and scoring code better.
Even though those are largely independent changes, perfectly happy to review
them together.
I mostly have NITs here, overall the changes LG.
Comment at: clangd/CodeComplete.cpp:36
+#define
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgrang, jkorous, MaskRay, ioeric,
mgorny, klimek.
Code completion scoring was embedded in CodeComplete.cpp, which is bad:
- awkward to test. The mechanisms (extracting info from ind
