[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

2018-05-12 Thread Kim Gräsman via Phabricator via cfe-commits
kimgr added a comment. It works! Having to specify `CMAKE_PREFIX_PATH` is at least documentable, so I don't see that as a major drawback, especially if it makes docs for tools using Clang more portable. Thank you for moving this along, now I can vastly simplify our CMake build. Repository:

[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

2018-05-12 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added a comment. In https://reviews.llvm.org/D46522#1096847, @kimgr wrote: > I'm interested in this, I've tried for a while to fix the Debian packaging > but I'm completely new to the packaging toolchain, so I'm making slow headway. The Debian clang-5.0 1:5.0.2-2 package already inc

[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

2018-05-12 Thread Kim Gräsman via Phabricator via cfe-commits
kimgr added a comment. I'm interested in this, I've tried for a while to fix the Debian packaging but I'm completely new to the packaging toolchain, so I'm making slow headway. Some of the problems are recorded in: https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=862328 My (possibly nai

[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

2018-05-09 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn abandoned this revision. Lekensteyn added a comment. Per discussion in https://reviews.llvm.org/D46521, resolving symlinks might introduce issues that are are worse than the issue that was solved here. It seems better to carry this patch downstream (in Debian) since the problem only

[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

2018-05-08 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added reviewers: brad.king, gottesmm, mgorny. Lekensteyn added a comment. Hi, this patch was required to make `find_package(Clang CONFIG)` work when `/usr/lib/llvm/clang-X.Y` was a symlink and is integrated in the Debian packaging. Please have a look, thanks! One unfortunate limitati

[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

2018-05-07 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn created this revision. Lekensteyn added a reviewer: sylvestre.ledru. Herald added subscribers: cfe-commits, mgorny. Ensure that symlinks such as /usr/lib/cmake/clang-X.Y (pointing to /usr/lib/llvm-X.Y/lib/cmake/llvm) are resolved. This ensures that CLANG_INSTALL_PREFIX ends up to be /us