[PATCH] D46489: [HIP] Let assembler output bitcode for amdgcn

2018-05-16 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl abandoned this revision. yaxunl added a comment. I have updated https://reviews.llvm.org/D46476 to skip backend and assembler phases for amdgcn, therefore this patch is no longer needed. https://reviews.llvm.org/D46489 ___ cfe-commits mailin

[PATCH] D46489: [HIP] Let assembler output bitcode for amdgcn

2018-05-15 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D46489#1099979, @yaxunl wrote: > In https://reviews.llvm.org/D46489#1088940, @rjmccall wrote: > > > I think the right solution here is to make a CompileJobAction with type > > TY_LLVM_BC in the first place. You should get the advice of a dri

[PATCH] D46489: [HIP] Let assembler output bitcode for amdgcn

2018-05-15 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D46489#1088940, @rjmccall wrote: > I think the right solution here is to make a CompileJobAction with type > TY_LLVM_BC in the first place. You should get the advice of a driver expert, > though. There is already JobAction for TY_LLVM_BC. I

[PATCH] D46489: [HIP] Let assembler output bitcode for amdgcn

2018-05-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I think the right solution here is to make a CompileJobAction with type TY_LLVM_BC in the first place. You should get the advice of a driver expert, though. https://reviews.llvm.org/D46489 ___ cfe-commits mailing list cf

[PATCH] D46489: [HIP] Let assembler output bitcode for amdgcn

2018-05-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. amdgcn does not support linking of object files, therefore let assembler output bitcode for HIP for amdgcn. https://reviews.llvm.org/D46489 Files: lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp