This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rC333483: Add action builder for HIP (authored by yaxunl,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46476?vs=148051&id=149012#toc
Reposit
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: test/Driver/cuda-phases.cu:16
+// RUN: | FileCheck -check-prefixes=BIN,BIN_NV %s
+// RUN: %clang -x hip -target powerpc64le-ibm-linux-gnu -ccc-print-phases
--cuda-gpu-arch=gfx803 %s 2>&1 \
+// RUN
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One nit. LGTM otherwise.
Comment at: test/Driver/cuda-phases.cu:16
+// RUN: | FileCheck -check-prefixes=BIN,BIN_NV %s
+// RUN: %clang -x hip -target powerpc64le-ibm-linux-gnu -ccc-
yaxunl added a comment.
ping
Any further changes are needed? Thanks.
https://reviews.llvm.org/D46476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 148051.
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D46476
Files:
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index: test/Driver/cuda-phases.cu
=
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Driver/Driver.cpp:2221
+CudaDeviceActions.clear();
+for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I) {
+ CudaDeviceActions.push_back(UA);
tra
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:2221
+CudaDeviceActions.clear();
+for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I) {
+ CudaDeviceActions.push_back(UA);
`for(auto Arch: GpuArchList)`
yaxunl added a comment.
ping
https://reviews.llvm.org/D46476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 147156.
yaxunl added a comment.
Skip backend and assemmbler phases for amdgcn since it does not support linking
of object files.
https://reviews.llvm.org/D46476
Files:
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index: test/Driver/cuda-phases.cu
=
