[PATCH] D46472: [HIP] Support offloading by linker script

2020-04-23 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1329 + // Get the HIP offload tool chain. + auto *HIPTC = static_cast( + C.getSingleOffloadToolChain()); JonChesterfield wrote

[PATCH] D46472: [HIP] Support offloading by linker script

2020-04-23 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Herald added a reviewer: jdoerfert. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1329 + // Get the HIP offload tool chain. + auto *HIPTC = static_cast( + C.getSingleOffloadToolChain()); Should this be `t

[PATCH] D46472: [HIP] Support offloading by linker script

2018-05-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1371-1388 + // machines. + LksStream << "/*\n"; + LksStream << " HIP Offload Linker Script\n"; + LksStream << " *** Automatically generated by Clang ***\n"; + LksStream << "*/\n";

[PATCH] D46472: [HIP] Support offloading by linker script

2018-05-18 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1371-1388 + // machines. + LksStream << "/*\n"; + LksStream << " HIP Offload Linker Script\n"; + LksStream << " *** Automatically generated by Clang ***\n"; + LksStream << "*/\n"; +

[PATCH] D46472: [HIP] Support offloading by linker script

2018-05-18 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1371-1388 + // machines. + LksStream << "/*\n"; + LksStream << " HIP Offload Linker Script\n"; + LksStream << " *** Automatically generated by Clang ***\n"; + LksStream << "*/\n"; +

[PATCH] D46472: [HIP] Support offloading by linker script

2018-05-18 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL332724: [HIP] Support offloading by linker script (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46472?vs=145480&id=1475

[PATCH] D46472: [HIP] Support offloading by linker script

2018-05-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D46472#1103577, @t-tye wrote: > LGTM except for minor suggestions. Thanks. Will make changes when committing. https://reviews.llvm.org/D46472 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D46472: [HIP] Support offloading by linker script

2018-05-17 Thread Tony Tye via Phabricator via cfe-commits
t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM except for minor suggestions. Comment at: lib/CodeGen/CGCUDANV.cpp:361-373 + if (IsHIP) +FatbinConstantName = ".hip_fatbin"; + else if (RelocatableDeviceCode) /

[PATCH] D46472: [HIP] Support offloading by linker script

2018-05-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping https://reviews.llvm.org/D46472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits