chill added a comment.
Ping?
https://reviews.llvm.org/D46439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chill marked an inline comment as done.
chill added a comment.
Update: updated comment, added a test.
Comment at: lib/Sema/SemaDecl.cpp:15651
}
} else {
ObjCIvarDecl **ClsFields =
rsmith wrote:
> Do we need to do any attribute processing in this Ob
chill updated this revision to Diff 145687.
https://reviews.llvm.org/D46439
Files:
lib/Sema/SemaDecl.cpp
test/Layout/itanium-pack-and-align.cpp
Index: test/Layout/itanium-pack-and-align.cpp
===
--- /dev/null
+++ test/Layout/ita
rsmith added a comment.
This looks fine, but needs a test.
Comment at: lib/Sema/SemaDecl.cpp:15576
+// Handle attributes before checking for alignas underalignment.
+if (Attr)
More generally: "before checking the layout".
Comment at
lebedev.ri added a comment.
Test?
Repository:
rC Clang
https://reviews.llvm.org/D46439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chill created this revision.
chill added reviewers: rsmith, aaron.ballman.
Executing the following program
#include
#include
struct S {
char x;
int y;
} __attribute__((packed, aligned(8)));
struct alignas(8) T {
char x;
int y;
} __attribute__((packed));
in
