a.sidorin closed this revision.
a.sidorin added a comment.
Closed with https://reviews.llvm.org/rC332256.
Repository:
rC Clang
https://reviews.llvm.org/D46398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D46398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
a.sidorin updated this revision to Diff 146589.
a.sidorin added a comment.
Add forgotten context.
Repository:
rC Clang
https://reviews.llvm.org/D46398
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
===
a.sidorin updated this revision to Diff 146587.
a.sidorin added a comment.
After a number of attempts of Twine'ifying all Code samples, I decided to
restore the initial state of this code.
Repository:
rC Clang
https://reviews.llvm.org/D46398
Files:
unittests/AST/ASTImporterTest.cpp
Inde
a.sidorin added subscribers: pcc, klimek.
a.sidorin added a comment.
Hi Gabor,
> Can't we have the same problem with FileName?
As I can see, no. FileName is copied into std::string while building
compilation arguments.
> Perhaps an other alternative would be to make the members real strings.
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:211
StringRef Code;
StringRef FileName;
std::unique_ptr Unit;
Can't we have the same problem with FileName?
Perhaps an other alternative would be to make the members real
a.sidorin created this revision.
a.sidorin added reviewers: xazax.hun, martong, szepet, jingham.
Herald added subscribers: cfe-commits, rnkovacs.
`buildASTFromCodeWithArgs()` accepts `llvm::Twine` as `Code` argument. However,
if the argument is not a C string or std::string, the argument is being
