This revision was automatically updated to reflect the committed changes.
Closed by commit rC331925: [Clang] Implement function attribute
no_stack_protector. (authored by manojgupta, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46300?vs=145988&id=146008#toc
Repository:
manojgupta added a comment.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D46300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
manojgupta updated this revision to Diff 145988.
manojgupta added a comment.
Updated test case for error msg with arguments.
Updated the documentation.
Repository:
rC Clang
https://reviews.llvm.org/D46300
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/Co
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1494
+def NoStackProtector : InheritableAttr {
+ let Spellings = [GCC<"no_stack_protector">];
+ let Subjects = SubjectList<[Function]>;
rnk wrote:
> aaron.ballman wrote:
> > manojgupta
rnk added inline comments.
Comment at: include/clang/Basic/Attr.td:1494
+def NoStackProtector : InheritableAttr {
+ let Spellings = [GCC<"no_stack_protector">];
+ let Subjects = SubjectList<[Function]>;
aaron.ballman wrote:
> manojgupta wrote:
> > aaron.ballman
aaron.ballman edited reviewers, added: probinson; removed: void.
aaron.ballman added a subscriber: probinson.
aaron.ballman added a comment.
Adding in @probinson as he originally added the `optnone` attribute. Paul, do
you recall why you opted (haha, pun totally intended) to implement `optnone`
manojgupta added inline comments.
Comment at: include/clang/Basic/Attr.td:1494
+def NoStackProtector : InheritableAttr {
+ let Spellings = [GCC<"no_stack_protector">];
+ let Subjects = SubjectList<[Function]>;
aaron.ballman wrote:
> This is not a GCC attribute,
manojgupta updated this revision to Diff 145514.
manojgupta added a comment.
Added docs, Sema test case for the attribute.
Repository:
rC Clang
https://reviews.llvm.org/D46300
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CodeGenModule.cpp
lib/Sema/Se
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Missing Sema tests that the attribute only appertains to functions, accepts no
arguments, etc.
Comment at: include/clang/Basic/Attr.td:1494
+def NoSt
srhines added a comment.
Looks fine. Please wait for a more experienced person to review this, however.
Thanks for adding this feature.
Repository:
rC Clang
https://reviews.llvm.org/D46300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
manojgupta created this revision.
manojgupta added reviewers: aaron.ballman, rsmith, rnk, void.
This attribute tells clang to skip this function from stack protector
when -stack-protector option is passed.
GCC option for this is:
__attribute__((__optimize__("no-stack-protector"))) and the
equivale
12 matches
Mail list logo
