[PATCH] D46258: [clangd] Also use UTF-16 in index position.

2018-04-30 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL331168: [clangd] Also use UTF-16 in index position. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46258 Files: clang-too

[PATCH] D46258: [clangd] Also use UTF-16 in index position.

2018-04-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 144540. hokein added a comment. Add a test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46258 Files: clangd/index/SymbolCollector.cpp unittests/clangd/SymbolCollectorTests.cpp Index: unittests/clangd/SymbolCollectorTests.cpp ===

[PATCH] D46258: [clangd] Also use UTF-16 in index position.

2018-04-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (oops, meant to accept this - please do add a test if you can) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46258 ___ cf

[PATCH] D46258: [clangd] Also use UTF-16 in index position.

2018-04-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Oops, I missed this, thanks! Possible to add a testcase? Any character that's not ASCII and is legal in an identifier should do it. http://en.cppreference.com/w/cpp/language/identifiers Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46258 _

[PATCH] D46258: [clangd] Also use UTF-16 in index position.

2018-04-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: jkorous, MaskRay, ioeric, ilya-biryukov, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46258 Files: clangd/index/SymbolCollector.cpp Index: clangd/index/SymbolCollector.cpp ==