This revision was automatically updated to reflect the committed changes.
Closed by commit rL331209: [Driver, CodeGen] rename options to disable an FP
cast optimization (authored by spatel, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331209: [Driver, CodeGen] rename options to disable an FP
cast optimization (authored by spatel, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D46236
Files:
docs/ReleaseNotes.rst
do
spatel updated this revision to Diff 144551.
spatel added a comment.
Patch updated:
Added "By default" to the description in the user manual and release notes to
make it clearer how this behaves.
https://reviews.llvm.org/D46236
Files:
docs/ReleaseNotes.rst
docs/UsersManual.rst
include/cl
rsmith added inline comments.
Comment at: docs/ReleaseNotes.rst:96
+ type, the code has undefined behavior according to the language standard.
+ Clang will not guarantee any particular result in that case. With the
+ 'no-strict' option, Clang attempts to match the overflowi
spatel updated this revision to Diff 144487.
spatel marked 6 inline comments as done.
spatel added a comment.
Patch updated:
1. Improved language in docs.
2. Added help text for clang options.
3. Added driver test with -fstrict-float-cast-overflow specified explicitly.
I'll leave this up for fur
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Overall makes sense to me.
Comment at: docs/ReleaseNotes.rst:94
+ :option:`-fno-strict-float-cast-overflow` -
+ When a floating-point value is not representable in
spatel updated this revision to Diff 144481.
spatel added a comment.
Patch updated:
I missed a spot in the release notes - forgot to delete 'workaround' when
listing the new options.
https://reviews.llvm.org/D46236
Files:
docs/ReleaseNotes.rst
docs/UsersManual.rst
include/clang/Driver/Op
spatel created this revision.
spatel added reviewers: rsmith, chandlerc, scanon, hans, echristo, jgorbe,
lebedev.ri.
Herald added a subscriber: mcrosier.
As suggested in the post-commit thread for https://reviews.llvm.org/rL331056,
we should match these clang options with the established vocabul
