[PATCH] D46183: [clangd] Incorporate #occurrences in scoring code complete results.

2018-05-03 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE331457: [clangd] Incorporate #occurrences in scoring code complete results. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D46183?vs=145021&id=145024#toc Re

[PATCH] D46183: [clangd] Incorporate #occurrences in scoring code complete results.

2018-05-03 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46183: [clangd] Incorporate #occurrences in scoring code complete results.

2018-05-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 145021. sammccall added a comment. Fix tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46183 Files: clangd/CodeComplete.cpp clangd/index/Index.cpp clangd/index/Index.h clangd/index/MemIndex.cpp unittests/clangd/CodeComplet

[PATCH] D46183: [clangd] Incorporate #occurrences in scoring code complete results.

2018-05-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Added a test - it's kind of perfunctory, I really want to organize symbol scoring more thoroughly which will provide a better place to test well. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46183 ___ c

[PATCH] D46183: [clangd] Incorporate #occurrences in scoring code complete results.

2018-05-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 145011. sammccall added a comment. Add completion test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46183 Files: clangd/CodeComplete.cpp clangd/index/Index.cpp clangd/index/Index.h clangd/index/MemIndex.cpp unittests/clangd/C

[PATCH] D46183: [clangd] Incorporate #occurrences in scoring code complete results.

2018-04-27 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. the patch LG and fixes the problem of llvm namespace not showing up in completions from the static index. Let's add some tests and ship it! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46183 ___ cfe

[PATCH] D46183: [clangd] Incorporate #occurrences in scoring code complete results.

2018-04-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, klimek. needs tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46183 Files: clangd/CodeComplete.cpp clangd/index/Index.cpp clan