[PATCH] D46155: Add warning flag -Wordered-compare-function-pointers.

2018-05-05 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Ideally there should be a test that verifies that `-Wordered-compare-function-pointers` / `-Wno-ordered-compare-function-pointers` / the default is what you expect it to be. Repository: rC Clang https://reviews.llvm.org/D46155

[PATCH] D46155: Add warning flag -Wordered-compare-function-pointers.

2018-05-04 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC331570: Add warning flag -Wordered-compare-function-pointers. (authored by efriedma, committed by ). Repository: rC Clang https://reviews.llvm.org/D46155 Files: include/clang/Basic/DiagnosticSemaKin

[PATCH] D46155: Add warning flag -Wordered-compare-function-pointers.

2018-04-26 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added a reviewer: rsmith. The C standard doesn't allow comparisons like "f1 < f2" (where f1 and f2 are function pointers), but we allow them as an extension. Add awarning flag to control this warning. (Not sure I like the name, but this seems to des