[PATCH] D46071: Representing the target device information in the LLVM IR

2018-04-25 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. I agree this needs an RFC; I don't understand how you plan to use this information. Repository: rOMP OpenMP https://reviews.llvm.org/D46071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D46071: Representing the target device information in the LLVM IR

2018-04-25 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Hmm, I don't think this is correct. I think it is against the OpenMP standard. According to OpenMP 4.5: When an original variable is mapped to a device data environment and the associated 19 corresponding variable is not present in the device data environment, a new corr

[PATCH] D46071: Representing the target device information in the LLVM IR

2018-04-25 Thread Jin Lin via Phabricator via cfe-commits
jinlin updated this revision to Diff 143967. https://reviews.llvm.org/D46071 Files: docs/LangRef.rst include/llvm/Bitcode/LLVMBitCodes.h include/llvm/IR/Module.h lib/AsmParser/LLLexer.cpp lib/AsmParser/LLParser.cpp lib/AsmParser/LLToken.h lib/Bitcode/Reader/BitcodeReader.cpp lib/B

[PATCH] D46071: Representing the target device information in the LLVM IR

2018-04-25 Thread Jin Lin via Phabricator via cfe-commits
jinlin updated this revision to Diff 143966. https://reviews.llvm.org/D46071 Files: docs/LangRef.rst include/llvm/Bitcode/LLVMBitCodes.h include/llvm/IR/Module.h lib/AsmParser/LLLexer.cpp lib/AsmParser/LLParser.cpp lib/AsmParser/LLToken.h lib/Bitcode/Reader/BitcodeReader.cpp lib/B

[PATCH] D46071: Representing the target device information in the LLVM IR

2018-04-25 Thread Jin Lin via Phabricator via cfe-commits
jinlin updated this revision to Diff 143965. https://reviews.llvm.org/D46071 Files: docs/LangRef.rst include/llvm/Bitcode/LLVMBitCodes.h include/llvm/IR/Module.h lib/AsmParser/LLLexer.cpp lib/AsmParser/LLParser.cpp lib/AsmParser/LLToken.h lib/Bitcode/Reader/BitcodeReader.cpp lib/B

[PATCH] D46071: Representing the target device information in the LLVM IR

2018-04-25 Thread Jin Lin via Phabricator via cfe-commits
jinlin updated this revision to Diff 143964. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D46071 Files: lib/CodeGen/ModuleBuilder.cpp Index: lib/CodeGen/ModuleBuilder.cpp === --- lib/Co