[PATCH] D46066: [analyzer] Add checker for underflowing unsigned integers

2018-04-25 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 abandoned this revision. pfultz2 added a comment. So I submitted my change to the ConversionChecker, instead. Repository: rC Clang https://reviews.llvm.org/D46066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D46066: [analyzer] Add checker for underflowing unsigned integers

2018-04-25 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 added a comment. > Isn't this case already covered by conversion checker? I was unaware of this. This looks like it only works for binary operators. So `f(-1)` won't get caught. Repository: rC Clang https://reviews.llvm.org/D46066 ___ c

[PATCH] D46066: [analyzer] Add checker for underflowing unsigned integers

2018-04-25 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Isn't this case already covered by conversion checker? https://github.com/llvm-mirror/clang/blob/master/lib/StaticAnalyzer/Checkers/ConversionChecker.cpp Repository: rC Clang https://reviews.llvm.org/D46066 ___ cfe-com

[PATCH] D46066: [analyzer] Add checker for underflowing unsigned integers

2018-04-25 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 created this revision. pfultz2 added reviewers: NoQ, xazax.hun, dkrupp, whisperity, george.karpenkov. pfultz2 added a project: clang. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, mgorny. This will check for when assigning a negative value to an unsigned integer, whe