[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rC332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D46050?vs=146999&id=147077#toc Repository:

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rL332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4605

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. If this is fine now, please submit as I don't have the permissions to do so. Repository: rC Clang https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 146999. nik added a comment. Addressed inline nit. Repository: rC Clang https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Index/complete-and-plugins.c Index: test/Index/complete-and-plugins.c ==

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: test/Index/complete-and-plugins.c:3 + +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. Ping https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. OK, the issue with the test dependencies I've had is resolved by https://reviews.llvm.org/D46514 https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 145430. nik added a comment. Moved the test to "Index". https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Index/complete-and-plugins.c Index: test/Index/complete-and-plugins.c =

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik marked an inline comment as done. nik added inline comments. Comment at: test/Frontend/plugins.c:8 +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-P

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

thakis added inline comments. Comment at: test/Frontend/plugins.c:7 + +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-PLUGINS %s +// REQUIRES: plugins,

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added inline comments. Comment at: test/Frontend/plugins.c:7 + +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-PLUGINS %s +// REQUIRES: plugins, ex

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 144084. nik added a comment. Added a test and clarified scenario in commit message. Repository: rC Clang https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Frontend/plugins.c Index: test/Frontend/plugins.c =

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. In https://reviews.llvm.org/D46050#1078112, @thakis wrote: > Seems reasonable; can you add a test for this (maybe somewhere in > clang/test/Frontend/plugin*)? Done. In https://reviews.llvm.org/D46050#1078155, @john.brawn wrote: > I know very little about how code complet

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

john.brawn added a comment. I know very little about how code completion works, but it's not immediately obvious to me that disabling plugin ast consumers when code completion is enabled is necessarily correct. In what kind of scenario would we both have a plugin loaded that wants to insert an

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

thakis added a comment. Seems reasonable; can you add a test for this (maybe somewhere in clang/test/Frontend/plugin*)? Repository: rC Clang https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 143894. nik added a comment. only clang-format fixes Repository: rC Clang https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp Index: lib/Frontend/FrontendAction.cpp === --

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik created this revision. Herald added a subscriber: cfe-commits. The parsing that is done for code completion is a special case that will discard any generated diagnostics, so avoid running plugins for this case in the first place to avoid performance penalties due to the plugins. Repository: