This revision was automatically updated to reflect the committed changes.
Closed by commit rL334692: [clang-format] Add SpaceBeforeCpp11BracedList
option. (authored by hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46024?vs=1509
rkirsling added a comment.
I'll need someone to commit. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
Ross, do you have commit access or do you need someone to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
rkirsling updated this revision to Diff 150984.
rkirsling added a comment.
Addressed feedback—thank you for the review!
Repository:
rC Clang
https://reviews.llvm.org/D46024
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/TokenAnn
klimek accepted this revision.
klimek added a comment.
In https://reviews.llvm.org/D46024#1129350, @hans wrote:
> In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote:
>
> > FWIW, please note that this space-before-brace style is not specific to
> > WebKit; CppCoreGuidelines exhibits it
hans added a comment.
In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote:
> FWIW, please note that this space-before-brace style is not specific to
> WebKit; CppCoreGuidelines exhibits it as well:
>
> http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initia
jfb added a comment.
In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote:
> FWIW, please note that this space-before-brace style is not specific to
> WebKit; CppCoreGuidelines exhibits it as well:
>
> http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initial
rkirsling added a comment.
FWIW, please note that this space-before-brace style is not specific to WebKit;
CppCoreGuidelines exhibits it as well:
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initializer-syntax
Repository:
rC Clang
https://reviews.llvm.org/D460
rkirsling updated this revision to Diff 149395.
rkirsling added a comment.
Resolved another rebase conflict to keep this patch mergeable.
Repository:
rC Clang
https://reviews.llvm.org/D46024
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
l
rkirsling added a comment.
@klimek In our IRC discussion yesterday, I know you expressed disapproval of
WebKit's choice, but given its reality, am I correct in concluding that this
can be landed?
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
rkirsling added a comment.
If there are no objections to this change, may I request a commit based on the
approval that @jfb provided?
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
rkirsling updated this revision to Diff 146355.
rkirsling added a comment.
Updated patch to resolve conflict and include full diff context.
Repository:
rC Clang
https://reviews.llvm.org/D46024
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
rkirsling added a comment.
Any further commentary? :)
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
On the WebKit side this lgtm. Let's leave some time for clang-format folks to
chime in.
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cf
rkirsling added a comment.
Rule has been published:
https://webkit.org/code-style-guidelines/#spacing-braced-init
Hopefully that suffices for motivation. :)
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-co
rkirsling added a comment.
Guidelines page has been updated (https://trac.webkit.org/changeset/231085),
though it may take a bit for the website to update.
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-com
rkirsling added a comment.
In https://reviews.llvm.org/D46024#1079390, @klimek wrote:
> Is this written down somewhere? https://webkit.org/code-style-guidelines/
> doesn't seem to mention it.
I agree that it really ought to be mentioned there—I'll try to bring that up
with the original author
klimek added a comment.
Is this written down somewhere? https://webkit.org/code-style-guidelines/
doesn't seem to mention it.
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
rkirsling created this revision.
rkirsling added reviewers: djasper, klimek.
Herald added a subscriber: cfe-commits.
WebKit C++ style for object initialization is as follows:
Foo foo { bar };
Yet using `clang-format -style=webkit` changes this to:
Foo foo{ bar };
As there is no existing co
19 matches
Mail list logo
