This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332460: [clangd] Parse all comments in Sema and
completion. (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46002?vs=146831&id=147064#toc
Repository:
rCTE
ilya-biryukov updated this revision to Diff 146831.
ilya-biryukov added a comment.
- Added tests that all comments are being parsed.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46002
Files:
clangd/ClangdUnit.cpp
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTest
ilya-biryukov updated this revision to Diff 145890.
ilya-biryukov added a comment.
- Moved tests to clang
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46002
Files:
clangd/ClangdUnit.cpp
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
=
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG (once the dependencies are done!)
Comment at: clangd/ClangdUnit.cpp:362
CI->getFrontendOpts().DisableFree = false;
+CI->getLangOpts()->CommentOpts.ParseAllC
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:362
CI->getFrontendOpts().DisableFree = false;
+CI->getLangOpts()->CommentOpts.ParseAllComments = true;
}
sammccall wrote:
> Any idea about whether this will affect performance sig
sammccall added a comment.
Code looks good/simple, just a couple of design questions
Comment at: clangd/ClangdUnit.cpp:362
CI->getFrontendOpts().DisableFree = false;
+CI->getLangOpts()->CommentOpts.ParseAllComments = true;
}
Any idea about whether t
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, hokein, ioeric.
Herald added subscribers: jkorous, MaskRay, klimek.
And add tests for the comment extraction code.
clangd will now show non-doxygen comments in completion for results
coming from Sema and Dynamic index.
