This revision was automatically updated to reflect the committed changes.
Closed by commit rC331164: [Targets] Implement getConstraintRegister for ARM
and AArch64 (authored by miyuki, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45965
Files:
include/clang/Basic/TargetInfo.
thopre accepted this revision.
thopre added a comment.
This revision is now accepted and ready to land.
As I said, LGTM. Please wait a few days (say next Monday) in case anyone else
has any objection.
https://reviews.llvm.org/D45965
___
cfe-commits
thopre added a comment.
FWIW LGTM.
https://reviews.llvm.org/D45965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thopre added inline comments.
Comment at: lib/Basic/Targets/AArch64.h:85-89
+ StringRef getConstraintRegister(StringRef Constraint,
+ StringRef Expression) const override {
+return Expression;
+ }
+
miyuki wrote:
> thopre wr
miyuki updated this revision to Diff 143732.
miyuki added a comment.
Added a comment for getConstraintRegister
https://reviews.llvm.org/D45965
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets/AArch64.h
lib/Basic/Targets/ARM.h
test/Sema/arm-asm.c
test/Sema/arm64-inline-asm.c
miyuki added inline comments.
Comment at: lib/Basic/Targets/AArch64.h:85-89
+ StringRef getConstraintRegister(StringRef Constraint,
+ StringRef Expression) const override {
+return Expression;
+ }
+
thopre wrote:
> From what
thopre added inline comments.
Comment at: lib/Basic/Targets/AArch64.h:85-89
+ StringRef getConstraintRegister(StringRef Constraint,
+ StringRef Expression) const override {
+return Expression;
+ }
+
From what I understood of
miyuki created this revision.
miyuki added a reviewer: eli.friedman.
Herald added subscribers: chrib, kristof.beyls, eraman, rengolin.
Herald added a reviewer: javed.absar.
The getConstraintRegister method is used by semantic checking of
inline assembly statements in order to diagnose conflicts be
