This revision was automatically updated to reflect the committed changes.
Closed by commit rL02: Convert clang-interpreter to ORC JIT API (authored
by sas, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45897?vs=143376&id=148656#t
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: mgrang.
Looks good to me. :)
Repository:
rC Clang
https://reviews.llvm.org/D45897
___
cfe-commits mailing list
cfe-
sas updated this revision to Diff 143376.
sas added a comment.
Review comments from @alexshap.
Repository:
rC Clang
https://reviews.llvm.org/D45897
Files:
examples/clang-interpreter/CMakeLists.txt
examples/clang-interpreter/Invoke.cpp
examples/clang-interpreter/Invoke.h
examples/clan
sas added inline comments.
Comment at: examples/clang-interpreter/main.cpp:52
+class SimpleJIT {
+private:
+ ExecutionSession ES;
alexshap wrote:
> not needed
Seems cleaner to me to have these explicit, and avoids potentiel code churn if
there are changes above
alexshap added inline comments.
Comment at: examples/clang-interpreter/main.cpp:52
+class SimpleJIT {
+private:
+ ExecutionSession ES;
not needed
Comment at: examples/clang-interpreter/main.cpp:84
+
+ TargetMachine &getTargetMachine() { retur
sas created this revision.
sas added reviewers: ddunbar, lhames.
Herald added a subscriber: mgorny.
This mostly re-uses code from the KaleidoscopeJIT example.
Repository:
rC Clang
https://reviews.llvm.org/D45897
Files:
examples/clang-interpreter/CMakeLists.txt
examples/clang-interpreter/
