This revision was automatically updated to reflect the committed changes.
Closed by commit rL330717: [CodeComplete] Fix completion at the end of keywords
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45887?vs=
ilya-biryukov updated this revision to Diff 143731.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
- Added comments
- Fix nits in tests
Repository:
rC Clang
https://reviews.llvm.org/D45887
Files:
lib/Lex/Lexer.cpp
test/CodeCompletion/end-of-ident-macro.cpp
ilya-biryukov added inline comments.
Comment at: lib/Lex/Lexer.cpp:1647
// looking up the identifier in the identifier table.
IdentifierInfo *II = PP->LookUpIdentifierInfo(Result);
sammccall wrote:
> move this down to where it's used - it's ignored fo
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice! I'm a little surprised that this wasn't fixed before, so I'm worried I
missing something.
But nobody else has reviewed it, and it really seems right (and the test cases
you fixed d
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, bkramer, arphaman, aaron.ballman.
Make completion behave consistently no matter if it is run at the
start, in the middle or at the end of an identifier that happens to
be a keyword or a macro name. Since completion is o
