zinovy.nis added a comment.
In https://reviews.llvm.org/D45776#1253944, @lebedev.ri wrote:
> >> Did this intentionally omit the possibility to pass a group of prefixes,
> >> like `FileCheck` supports?
> >> Usefulness of this feature is somewhat penalized by this.
Done. Please review this http
lebedev.ri added a comment.
In https://reviews.llvm.org/D45776#1253934, @zinovy.nis wrote:
> In https://reviews.llvm.org/D45776#1251256, @lebedev.ri wrote:
>
> > Did this intentionally omit the possibility to pass a group of prefixes,
> > like `FileCheck` supports?
> > Usefulness of this featur
lebedev.ri added a comment.
In https://reviews.llvm.org/D45776#1253934, @zinovy.nis wrote:
> In https://reviews.llvm.org/D45776#1251256, @lebedev.ri wrote:
>
> > Did this intentionally omit the possibility to pass a group of prefixes,
> > like `FileCheck` supports?
> > Usefulness of this featur
zinovy.nis added a comment.
In https://reviews.llvm.org/D45776#1251256, @lebedev.ri wrote:
> Did this intentionally omit the possibility to pass a group of prefixes, like
> `FileCheck` supports?
> Usefulness of this feature is somewhat penalized by this.
I did not fully realize what do you me
lebedev.ri added a comment.
Herald added a subscriber: arphaman.
Did this intentionally omit the possibility to pass a group of prefixes, like
`FileCheck` supports?
Usefulness of this feature is somewhat penalized by this.
Repository:
rL LLVM
https://reviews.llvm.org/D45776
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330511: [clang-tidy] Customize FileCheck prefix in
check_clang-tidy.py (authored by zinovy.nis, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D45776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
zinovy.nis updated this revision to Diff 143436.
zinovy.nis marked 3 inline comments as done.
zinovy.nis added a comment.
- Applied the changes suggested by Alexander.
https://reviews.llvm.org/D45776
Files:
docs/clang-tidy/index.rst
test/clang-tidy/check_clang_tidy.cpp
test/clang-tidy/che
alexfh added a comment.
A few style-related comments.
Comment at: docs/clang-tidy/index.rst:677
+To check more than one scenario in the same test file use
+``-check-suffix=SUFFIX_NAME`` on ``check_clang_tidy.py`` command line.
+With ``-check-suffix=SUFFIX_NAME`` you need to re
zinovy.nis updated this revision to Diff 143384.
zinovy.nis edited the summary of this revision.
zinovy.nis added a comment.
- Minor cosmetic fixes.
https://reviews.llvm.org/D45776
Files:
docs/clang-tidy/index.rst
test/clang-tidy/check_clang_tidy.cpp
test/clang-tidy/check_clang_tidy.py
I
zinovy.nis added inline comments.
Comment at: test/clang-tidy/check_clang_tidy.py:77
+
+ check_fixes_prefix = 'CHECK-FIXES' + args.check_suffix
+ check_messages_prefix = 'CHECK-MESSAGES' + args.check_suffix
alexfh wrote:
> Maybe the script should add a dash whe
zinovy.nis added a comment.
Done.
https://reviews.llvm.org/D45776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zinovy.nis updated this revision to Diff 143053.
zinovy.nis added a comment.
- Removed exec attribute on file.
https://reviews.llvm.org/D45776
Files:
docs/clang-tidy/index.rst
test/clang-tidy/check_clang_tidy.cpp
test/clang-tidy/check_clang_tidy.py
Index: test/clang-tidy/check_clang_tidy
zinovy.nis updated this revision to Diff 143052.
zinovy.nis added a comment.
- Updated docs.
https://reviews.llvm.org/D45776
Files:
docs/clang-tidy/index.rst
test/clang-tidy/check_clang_tidy.cpp
test/clang-tidy/check_clang_tidy.py
Index: test/clang-tidy/check_clang_tidy.py
==
zinovy.nis updated this revision to Diff 143050.
zinovy.nis marked 4 inline comments as done.
zinovy.nis added a comment.
- Fixed issues pointed by Alexander.
https://reviews.llvm.org/D45776
Files:
test/clang-tidy/check_clang_tidy.cpp
test/clang-tidy/check_clang_tidy.py
Index: test/clang-
alexfh added a comment.
Thank you for the contribution!
Please update the documentation accordingly
(http://clang.llvm.org/extra/clang-tidy/#testing-checks).
> // RUN: %check_clang_tidy %s misc-unused-using-decls %t
> -check_suffix=-FLAG_1--
I don't know whether it makes sense to endorse (or
zinovy.nis created this revision.
zinovy.nis added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
The patch introduces a new command line option `-check_suffix` to allow
multiple %check_clang_tidy% in tests.
Sample:
// RUN: %check_clang_tidy %s misc-unused-usi
17 matches
Mail list logo
