This revision was automatically updated to reflect the committed changes.
Closed by commit rL330609: [clangd][tests] Fix delimiter handling (authored by
jkorous, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.org/D45764?vs=142918&id
sammccall added a comment.
In https://reviews.llvm.org/D45764#1072067, @jkorous wrote:
> [ultranit] Sorry, just to be sure - did you really mean any number of dashes
>
> if (LineRef.startswith("-") && LineRef.find_first_not_of('-') ==
> llvm::StringRef::npos)
>
>
> or at least three?
>
> if
jkorous added a comment.
[ultranit] Sorry, just to be sure - did you really mean any number of dashes
if (LineRef.startswith("-") && LineRef.find_first_not_of('-') ==
llvm::StringRef::npos)
or at least three?
if (LineRef.startswith("---") && LineRef.find_first_not_of('-') ==
llvm::StringR
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Oops, thanks! LG, optional suggestion
Comment at: JSONRPCDispatcher.cpp:281
// found a delimiter
-if (LineRef.find_first_not_of('-') == llvm::StringRef::npos)
jkorous added a reviewer: sammccall.
jkorous added a comment.
Hi Sam, could you please take a look at this minor fix?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple,
ilya-biryukov.
Empty line shouldn't be considered a delimiter.
Following https://reviews.llvm.org/D45763
Repository:
rCTE Clang Tools Extra
https
