[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

aaron.ballman accepted this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D45686#1115836, @dstenb wrote: > Any more comments or concerns, or can I land this? None from me; you're good to land it. Any further comments can be handled post-commit. https://reviews.llvm.org

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

dstenb added a comment. Any more comments or concerns, or can I land this? https://reviews.llvm.org/D45686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks David, LGTM https://reviews.llvm.org/D45686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

dstenb updated this revision to Diff 148791. dstenb added a comment. Update patch to include the clang-tools-extra test case originally added in https://reviews.llvm.org/D47251. https://reviews.llvm.org/D45686 Files: cfe/trunk/include/clang/Driver/Compilation.h cfe/trunk/lib/Driver/Compila

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

Ka-Ka added a comment. In https://reviews.llvm.org/D45686#1113426, @lebedev.ri wrote: > In https://reviews.llvm.org/D45686#1113425, @Ka-Ka wrote: > > > In https://reviews.llvm.org/D45686#1113414, @aaron.ballman wrote: > > > > > In https://reviews.llvm.org/D45686#1109295, @dstenb wrote: > > > > >

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

lebedev.ri added a comment. In https://reviews.llvm.org/D45686#1113425, @Ka-Ka wrote: > In https://reviews.llvm.org/D45686#1113414, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D45686#1109295, @dstenb wrote: > > > > > Ping. > > > > > > We have added a lit reproducer for this now in cla

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

Ka-Ka added a comment. In https://reviews.llvm.org/D45686#1113414, @aaron.ballman wrote: > In https://reviews.llvm.org/D45686#1109295, @dstenb wrote: > > > Ping. > > > > We have added a lit reproducer for this now in clang-tools-extra: > > https://reviews.llvm.org/D47251. > > > The above should

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

aaron.ballman added a comment. In https://reviews.llvm.org/D45686#1109295, @dstenb wrote: > Ping. > > We have added a lit reproducer for this now in clang-tools-extra: > https://reviews.llvm.org/D47251. The above should be rolled into this patch as the test case verifying the behavioral chang

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

Ka-Ka added a reviewer: JDevlieghere. Ka-Ka added a comment. Added Jonas Devlieghere as reviewer as he was involved in the review of https://reviews.llvm.org/rL327851 (which seems to be the reason for this patch). https://reviews.llvm.org/D45686 __

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

dstenb updated this revision to Diff 148604. dstenb added a comment. Query TheDriver.isSaveTempsEnabled() at uses instead of storing the value in the constructor. https://reviews.llvm.org/D45686 Files: include/clang/Driver/Compilation.h lib/Driver/Compilation.cpp lib/Driver/Driver.cpp

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

lebedev.ri added a comment. LGTM, but i'm quite unfamiliar with this area of the code, so please wait for someone else to accept :) Comment at: lib/Driver/Compilation.cpp:276-277 + + // Temporary files added by diagnostics should be kept. + SaveTempsEnabled = true; } ---

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

dstenb added inline comments. Comment at: lib/Driver/Compilation.cpp:276-277 + + // Temporary files added by diagnostics should be kept. + SaveTempsEnabled = true; } lebedev.ri wrote: > Is there a test that breaks without this? Yes, the following tests fail:

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

erichkeane added inline comments. Comment at: lib/Driver/Compilation.cpp:42 + TranslatedArgs(_TranslatedArgs), ContainsError(ContainsError), + KeepTempFiles(D.isSaveTempsEnabled()) { // The offloading host toolchain is the default toolchain. I'd pref

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

dstenb updated this revision to Diff 148592. dstenb marked an inline comment as done. dstenb added a comment. Renamed SaveTempsEnabled field to KeepTempFiles. https://reviews.llvm.org/D45686 Files: include/clang/Driver/Compilation.h lib/Driver/Compilation.cpp lib/Driver/Driver.cpp Index

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

lebedev.ri added inline comments. Comment at: include/clang/Driver/Compilation.h:126 + /// Whether to save temporary files. + bool SaveTempsEnabled; + `KeepTempFiles`? Comment at: lib/Driver/Compilation.cpp:276-277 + + // Temporary files add

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

dstenb updated this revision to Diff 148577. dstenb retitled this revision from "[Tooling] Clean up tmp files when creating a fixed compilation database" to "[Driver] Clean up tmp files when deleting Compilation objects". dstenb edited the summary of this revision. dstenb added a comment. I have