NoQ added a comment.
Thanks! I noticed the problem but never investigated it.
Repository:
rC Clang
https://reviews.llvm.org/D45611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331361: [analyzer] Fix filename in cross-file HTML report
(authored by malcolm.parsons, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45611?vs=144742&id=144881#toc
Repository:
rC
george.karpenkov accepted this revision.
george.karpenkov added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D45611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
malcolm.parsons updated this revision to Diff 144742.
malcolm.parsons added a comment.
Add test
Repository:
rC Clang
https://reviews.llvm.org/D45611
Files:
lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
test/Coverage/html-multifile-diagnostics.c
Index: test/Coverage/html-multifile-diagnos
vlad.tsyrklevich accepted this revision.
vlad.tsyrklevich added a comment.
This revision is now accepted and ready to land.
This LGTM, but 1) you should add a test, probably just need to another CHECK to
test/Coverage/html-multifile-diagnostics.c from
https://reviews.llvm.org/D30406, and 2) some
malcolm.parsons created this revision.
malcolm.parsons added reviewers: george.karpenkov, dcoughlin, vlad.tsyrklevich.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
The filename is currently taken from the start of the path, while the
line and column are taken from the end o
