This revision was automatically updated to reflect the committed changes.
Closed by commit rL330229: [AAch64] Add the __ARM_FEATURE_DOTPROD macro
definition (authored by flyingforyou, committed by ).
Herald added subscribers: llvm-commits, chrib.
Changed prior to commit:
https://reviews.llvm.or
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D45544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
flyingforyou updated this revision to Diff 142265.
flyingforyou added a comment.
Addressed SjoerdMeijer' new comments. Thanks.
> Also wanted to confirm that macro __ARM_FEATURE_DOTPROD will defined/included
> in the next release of the ACLE.
Could you check it, please? I saw several codes that
SjoerdMeijer added a comment.
Hi, thanks for adding this.
Also wanted to confirm that macro __ARM_FEATURE_DOTPROD will defined/included
in the next release of the ACLE.
Comment at: lib/Basic/Targets/AArch64.h:36
unsigned HasFullFP16;
+ unsigned HasDotProd;
llvm::AArch6
flyingforyou created this revision.
flyingforyou added a reviewer: SjoerdMeijer.
Herald added subscribers: kristof.beyls, javed.absar.
This matches what GCC does.
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/aarch64/aarch64-c.c
https://reviews.llvm.org/D45544
Files:
lib/Basic/Targ