This revision was automatically updated to reflect the committed changes.
Closed by commit rL329770: [libcxx] Set ABI version 2 as default for Fuchsia
(authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45304?vs=141935
phosek updated this revision to Diff 141935.
phosek marked an inline comment as done.
Repository:
rCXX libc++
https://reviews.llvm.org/D45304
Files:
libcxx/include/__config
Index: libcxx/include/__config
===
--- libcxx/include
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: libcxx/include/__config:39
#ifndef _LIBCPP_ABI_VERSION
+#ifdef __Fuchsia__
+#define _LIBCPP_ABI_VERSION 2
Please indent these nested `#ifd
phosek updated this revision to Diff 141933.
phosek marked an inline comment as done.
Repository:
rCXX libc++
https://reviews.llvm.org/D45304
Files:
libcxx/include/__config
Index: libcxx/include/__config
===
--- libcxx/include
EricWF added inline comments.
Comment at: libcxx/CMakeLists.txt:100
"LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY;LIBCXX_INSTALL_LIBRARY" OFF)
-set(LIBCXX_ABI_VERSION 1 CACHE STRING "ABI version of libc++.")
+if (FUCHSIA)
+ set(ABI_VERSION_DEFAULT 2)
I don't thin
phosek added a comment.
I don't like this but I'm not sure if there's a better way to do this, do you
have any ideas?
Repository:
rCXX libc++
https://reviews.llvm.org/D45304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
phosek created this revision.
phosek added a reviewer: EricWF.
Herald added subscribers: cfe-commits, christof, mgorny.
phosek added a comment.
I don't like this but I'm not sure if there's a better way to do this, do you
have any ideas?
This avoids the need for a custom generated config file.
