[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

2018-04-04 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329236: AArch64: Implement support for the shadowcallstack attribute. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D45239?vs=141063&id=141068#toc Repository: rL

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

2018-04-04 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc updated this revision to Diff 141063. pcc marked 3 inline comments as done. pcc added a comment. - Addres review comments https://reviews.llvm.org/D45239 Files: clang/docs/ShadowCallStack.rst clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolChain.cpp clang/test/Driver/sanitiz

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

2018-04-04 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added inline comments. Comment at: clang/docs/ShadowCallStack.rst:12 ShadowCallStack is an **experimental** instrumentation pass, currently only implemented for x86_64, that protects programs against return address overwrites (e.g. stack buffer overflows.) It works by

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

2018-04-04 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich accepted this revision. vlad.tsyrklevich added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ShadowCallStack.rst:12 ShadowCallStack is an **experimental** instrumentation pass, currently only implemented for x86_64, th

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

2018-04-03 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. pcc added reviewers: vlad.tsyrklevich, eugenis, kcc, t.p.northover, olista01. Herald added subscribers: hiraditya, kristof.beyls, javed.absar, rengolin. The implementation of shadow call stack on aarch64 is quite different to the implementation on x86_64. Instead of rese