[PATCH] D45237: [RISCV] Fix logic check if frame pointer should be used

asb added a comment. Could you please add a test, perhaps to test/Driver/frame-pointer.c? My understanding is that in general there is a desire for codegen to remain the same or as close as possible whether it's a -g build or not, so I think disabling fp elimination for debug builds wouldn't be

[PATCH] D45237: [RISCV] Fix logic check if frame pointer should be used

mgrang added a comment. @asb Should we keep frame pointer enabled for debug builds? Internally, for ARM/Thumb we leave frame pointer ON if debug is enabled. Repository: rC Clang https://reviews.llvm.org/D45237 ___ cfe-commits mailing list cfe-co

[PATCH] D45237: [RISCV] Fix logic check if frame pointer should be used

mgrang created this revision. mgrang added a reviewer: asb. Herald added subscribers: shiva0217, kito-cheng. The logic was broken for Linux triples as it returns true in the switch for Triple.isOSLinux(). Repository: rC Clang https://reviews.llvm.org/D45237 Files: lib/Driver/ToolChains/Cl