[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

rinon abandoned this revision. rinon added a comment. Looks like this was effectively implemented in c4d75361 , so this change is no longer necessary. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

shafik added a comment. Herald added a project: All. Is this change still relevant of can we close this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45234/new/ https://reviews.llvm.org/D45234 ___ cfe-commits mailing

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D45234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

rinon added a comment. I'd be fine with not building c-index-test when building clang, but I didn't see any easy way to disable it. My use-case here is just to build LLVM+clang without having to link against my system libxml2 at all. It's a rather weird build situation, but Android builds a to

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

rnk added a comment. The only think that links against libxml2 is c-index-test. Surely nobody cares about installing c-index-test on some other machine that lacks the local version of libxml2. What's the use case for this to justify the complexity of interacting with LLVM's configuration option

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

rinon created this revision. rinon added reviewers: hans, rnk. Herald added subscribers: cfe-commits, mgorny. If LLVM_ENABLE_LIBXML2=OFF, we should not attempt to link clang against libxml2. Repository: rC Clang https://reviews.llvm.org/D45234 Files: CMakeLists.txt Index: CMakeLists.txt