This revision was automatically updated to reflect the committed changes.
Closed by commit rC329298: [clang-format] Support lightweight Objective-C
generics (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45185?vs=140968&id=141163#toc
Repository:
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
Repository:
rC Clang
https://reviews.llvm.org/D45185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
benhamilton updated this revision to Diff 140968.
benhamilton marked 3 inline comments as done.
benhamilton added a comment.
- @djasper fixes
Repository:
rC Clang
https://reviews.llvm.org/D45185
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestObjC.cpp
Index: unitte
benhamilton added a comment.
Thanks, fixed!
Comment at: lib/Format/UnwrappedLineParser.cpp:2135
+nextToken();
+if (FormatTok->Tok.is(tok::less))
+ NumOpenAngles++;
djasper wrote:
> The UnwrappedLineParser is very much about error recovery. Implemen
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2135
+nextToken();
+if (FormatTok->Tok.is(tok::less))
+ NumOpenAngles++;
The UnwrappedLineParser is very much about error recovery. Implemented like
this, it will consume
benhamilton created this revision.
benhamilton added reviewers: djasper, jolesiak.
Herald added subscribers: cfe-commits, klimek.
Previously, `clang-format` didn't understand lightweight
Objective-C generics, which have the form:
@interface Foo , ... > ...
The lightweight generic specifier lis
