This revision was automatically updated to reflect the committed changes.
Closed by commit rL329032: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and
tests (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45145?
phosek updated this revision to Diff 140668.
phosek added a comment.
Thanks for the suggestion, I don't think we even need to rename the function
since this already matches the pattern other functions use.
Repository:
rC Clang
https://reviews.llvm.org/D45145
Files:
clang/lib/Driver/ToolCh
pirama added a comment.
Hi Petr, thanks for the fix (I dropped the ball on this one :( ). Instead of
duplicating the checks, does it make sense to fold check into
addArchSpecificRPath and rename it to 'addArchSpecificRPathIfRequested' or
something similar?
Repository:
rC Clang
https://rev
phosek created this revision.
phosek added reviewers: rnk, pirama, bkramer, mgorny.
Herald added a subscriber: cfe-commits.
https://reviews.llvm.org/D30700 added the -f[no-]rtlib-add-rpath flag, but that
flag was never
wired up in the driver and tests were updated to check whether it
actually doe
