This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX329490: [libcxx][test] Silence -Wself-assign diagnostics
(authored by lebedevri, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D45128
Files:
test/std/utilities/any/any.class/any
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Perhaps we could add a comment for the first such occurrence of the cast
in each file explaining it.
Repository:
rCXX libc++
https://reviews.llvm.org/D45128
__
lebedev.ri updated this revision to Diff 140788.
lebedev.ri added a comment.
The diagnostic was adjusted not to warn in an unevaluated context.
The remaining diff will have to remain, unless you want to disable
`-Wself-assign` altogether for tests...
If there are remaining problems with this dif
lebedev.ri added inline comments.
Comment at:
test/std/language.support/support.types/byteops/and.assign.pass.cpp:30
-static_assert(noexcept(b &= b), "" );
+static_assert(noexcept(b &= (std::byte &)b), "" );
Quuxplusone wrote:
> lebedev.ri wrote:
> >
Quuxplusone added inline comments.
Comment at:
test/std/language.support/support.types/byteops/and.assign.pass.cpp:30
-static_assert(noexcept(b &= b), "" );
+static_assert(noexcept(b &= (std::byte &)b), "" );
lebedev.ri wrote:
> EricWF wrote:
> > Sho
lebedev.ri added inline comments.
Comment at:
test/std/language.support/support.types/byteops/and.assign.pass.cpp:30
-static_assert(noexcept(b &= b), "" );
+static_assert(noexcept(b &= (std::byte &)b), "" );
EricWF wrote:
> Should Clang really be war
EricWF added inline comments.
Comment at:
test/std/language.support/support.types/byteops/and.assign.pass.cpp:30
-static_assert(noexcept(b &= b), "" );
+static_assert(noexcept(b &= (std::byte &)b), "" );
Should Clang really be warning when the expres
lebedev.ri created this revision.
lebedev.ri added reviewers: mclow.lists, EricWF.
https://reviews.llvm.org/D44883 extends -Wself-assign to also work on C++
classes.
These new warnings pop up in the test suite, so they have to be silenced.
Please refer to the https://reviews.llvm.org/D45082 for
