[PATCH] D45126: Xray, OpenBSD support

This revision was automatically updated to reflect the committed changes. Closed by commit rC329183: [XRay][clang] Allow clang to build XRay instrumented binaries in OpenBSD (authored by dberris, committed by ). Repository: rC Clang https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChai

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. Yes I can t land anything myself :-) thanks ! https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45126: Xray, OpenBSD support

dberris added a comment. Do you need to have someone land this for you, or can you land it yourself? If @brad isn't able to get to it anytime soon, then I'm happy for this to land either way. https://reviews.llvm.org/D45126 ___ cfe-commits mailing

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. Just realised he s not active since February, hopes it will make it somehow :-) https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D45126: Xray, OpenBSD support

dberris accepted this revision. dberris added a comment. LGTM -- I'll defer to @brad on confirming and landing. https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. > Fixed: http://llvm.org/PR36985 Nice ! The NetBSD version will benefit it as well (not sure it s really done in the frontend side). https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D45126: Xray, OpenBSD support

devnexen updated this revision to Diff 140762. https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp === --- lib/Driver/XRayArgs.cpp +++ lib/Driver/XRayA

[PATCH] D45126: Xray, OpenBSD support

dberris added inline comments. Comment at: lib/Driver/XRayArgs.cpp:53 +} else if (Triple.getOS() == llvm::Triple::FreeBSD || + Triple.getOS() == llvm::Triple::OpenBSD) { if (Triple.getArch() != llvm::Triple::x86_64) { I just noticed this

[PATCH] D45126: Xray, OpenBSD support

dberris added a comment. In https://reviews.llvm.org/D45126#1055451, @devnexen wrote: > In https://reviews.llvm.org/D45126#1055266, @dberris wrote: > > > LGTM -- at some point, it would be good to refactor all these flag settings > > to a single place. Maybe file a bug so that we can track that

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. In https://reviews.llvm.org/D45126#1055266, @dberris wrote: > LGTM -- at some point, it would be good to refactor all these flag settings > to a single place. Maybe file a bug so that we can track that issue on XRay? > If you can't do it now, I'd be happy to do it late

[PATCH] D45126: Xray, OpenBSD support

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM -- at some point, it would be good to refactor all these flag settings to a single place. Maybe file a bug so that we can track that issue on XRay? If you can't do it now, I'd be happy

[PATCH] D45126: Xray, OpenBSD support

devnexen created this revision. devnexen added a reviewer: brad. Herald added subscribers: cfe-commits, krytarowski, dberris. Enabling Xray in OpenBSD Repository: rC Clang https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver