[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

2018-04-10 Thread Artem Belevich via Phabricator via cfe-commits
tra abandoned this revision. tra marked an inline comment as done. tra added a comment. I've figured out a manageable way to enforce constraints without this change. https://reviews.llvm.org/D45060 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

2018-03-29 Thread Artem Belevich via Phabricator via cfe-commits
tra marked an inline comment as done. tra added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:933 + /// FeatureMap. Targets may override this to provide custom handling of + /// required features. + virtual Optional jlebar wrote: > It's n

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

2018-03-29 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 140371. tra added a comment. Updated description of hasRequiredFeature. Set FirstMissing if target returns 'false' so diags still work. https://reviews.llvm.org/D45060 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CodeGenFunction.cpp Ind

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

2018-03-29 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/TargetInfo.h:933 + /// FeatureMap. Targets may override this to provide custom handling of + /// required features. + virtual Opt

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

2018-03-29 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: echristo. Herald added subscribers: jlebar, sanjoy. In some cases figuring out whether particular target builtin should be enabled is a bit more complicated than current implementation allow. This patch allows the target to override what it consider