This revision was automatically updated to reflect the committed changes.
Closed by commit rL328793: Disable emitting static extern C aliases for amdgcn
target for CUDA (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
rjmccall accepted this revision.
rjmccall added a comment.
LGTM.
https://reviews.llvm.org/D44987
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 140129.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Add a target hook as suggested by John.
https://reviews.llvm.org/D44987
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/TargetInfo.cpp
lib/CodeGen/TargetInfo.h
test/CodeGenC
rjmccall added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:4684
+ (Context.getTargetInfo().getTriple().getArch() == llvm::Triple::amdgcn))
return;
for (auto &I : StaticExternCValues) {
Please add a target hook for this instead of build
yaxunl created this revision.
yaxunl added a reviewer: rjmccall.
Patch by Greg Rodgers.
Lit test added by Yaxun Liu.
https://reviews.llvm.org/D44987
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCUDA/alias.cu
Index: test/CodeGenCUDA/alias.cu
