This revision was automatically updated to reflect the committed changes.
Closed by commit rL330790: [HIP] Add hip input kind and codegen for kernel
launching (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44984?v
rjmccall accepted this revision.
rjmccall added a comment.
Thank you.
https://reviews.llvm.org/D44984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 143800.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Add back HIP related changes to the tests.
https://reviews.llvm.org/D44984
Files:
include/clang/Basic/IdentifierTable.h
include/clang/Basic/LangOptions.def
include/clang/Frontend/
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: test/CodeGenCUDA/device-stub.cu:2-8
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s \
+// RUN: -fcuda-include-gpubinary %t -o - | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-
tra added inline comments.
Comment at: test/CodeGenCUDA/device-stub.cu:2-8
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s \
+// RUN: -fcuda-include-gpubinary %t -o - | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s \
+// RUN: -fcuda-includ
yaxunl updated this revision to Diff 143792.
yaxunl added a comment.
Remove CodeGenModule argument from addPrefix* functions.
https://reviews.llvm.org/D44984
Files:
include/clang/Basic/IdentifierTable.h
include/clang/Basic/LangOptions.def
include/clang/Frontend/FrontendOptions.h
include
tra added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:51-52
llvm::Constant *getLaunchFn() const;
+ std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const;
+ std::string addUnderscoredPrefixToName(CodeGenModule &CGM,
+
rjmccall added a comment.
Otherwise LGTM.
Comment at: lib/CodeGen/CGCUDANV.cpp:51-52
llvm::Constant *getLaunchFn() const;
+ std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const;
+ std::string addUnderscoredPrefixToName(CodeGenModule &CGM,
+
yaxunl added a comment.
ping
https://reviews.llvm.org/D44984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 142978.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D44984
Files:
include/clang/Basic/IdentifierTable.h
include/clang/Basic/LangOptions.def
include/clang/Frontend/FrontendOption
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:466-467
Builder.defineMacro("__ASSEMBLER__");
if (LangOpts.CUDA)
Builder.defineMacro("__CUDA__");
+ if (LangOpts.HIP)
tra wrote:
> I
tra added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:51-52
llvm::Constant *getLaunchFn() const;
+ std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const;
+ std::string addUnderscoredPrefixToName(CodeGenModule &CGM,
+
yaxunl updated this revision to Diff 142818.
yaxunl marked an inline comment as done.
yaxunl retitled this revision from "[HIP] Add hip file type and codegen for
kernel launching" to "[HIP] Add hip input kind and codegen for kernel
launching".
yaxunl edited the summary of this revision.
yaxunl ad
13 matches
Mail list logo
