This revision was automatically updated to reflect the committed changes.
Closed by commit rC330833: [CodeComplete] Fix completion in the middle of ident
in ctor lists. (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44932?vs=143935&id=143942#toc
Repo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330833: [CodeComplete] Fix completion in the middle of ident
in ctor lists. (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org
ilya-biryukov updated this revision to Diff 143935.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Fix the comment
Repository:
rC Clang
https://reviews.llvm.org/D44932
Files:
lib/Lex/Lexer.cpp
test/CodeCompletion/ctor-initializer.cpp
test/CodeCompletio
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, modulo a tiny commenting nit.
Comment at: lib/Lex/Lexer.cpp:1667
+ // Note that code completion token is not added as a separate character
+ //
ilya-biryukov added inline comments.
Comment at: lib/Lex/Lexer.cpp:1667-1668
+ assert(CurPtr < BufferEnd && "eof at completion point");
+ while (isIdentifierBody(*CurPtr))
+++CurPtr;
+ BufferPtr = CurPtr;
aaron.ballman wrote:
> You should c
ilya-biryukov updated this revision to Diff 143435.
ilya-biryukov added a comment.
- Fixed failing assert on the end of file. Added a test for that.
Repository:
rC Clang
https://reviews.llvm.org/D44932
Files:
lib/Lex/Lexer.cpp
test/CodeCompletion/ctor-initializer.cpp
test/CodeCompletio
aaron.ballman added a reviewer: rsmith.
aaron.ballman added inline comments.
Comment at: lib/Lex/Lexer.cpp:1667-1668
+ assert(CurPtr < BufferEnd && "eof at completion point");
+ while (isIdentifierBody(*CurPtr))
+++CurPtr;
+ BufferPtr = CurPtr;
ilya-biryukov added a reviewer: arphaman.
ilya-biryukov added a comment.
+Alex, in case he might know someone who can review it.
Repository:
rC Clang
https://reviews.llvm.org/D44932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, aaron.ballman, bkramer, sepavloff.
The example that was broken before (^ designate completion points):
class Foo {
Foo() : fie^ld^() {} // no completions were provided here.
int field;
};
To fix it we don'
